Skip to content

This PR is to add comments to TestGetMasterPodInfo in pkg\ddc\alluxio\utils_test.go.#4636

Merged
cheyang merged 2 commits intofluid-cloudnative:masterfrom
PurpleViper3:new-branch
Mar 20, 2025
Merged

This PR is to add comments to TestGetMasterPodInfo in pkg\ddc\alluxio\utils_test.go.#4636
cheyang merged 2 commits intofluid-cloudnative:masterfrom
PurpleViper3:new-branch

Conversation

@PurpleViper3
Copy link
Copy Markdown
Contributor

Ⅰ. Describe what this PR does

This PR is to add comments to TestGetMasterPodInfo in pkg\ddc\alluxio\utils_test.go.

Ⅱ. Does this pull request fix one issue?

fixes #4635

Ⅲ. Special notes for reviews

nothing

Signed-off-by: cbkjames23 <1411137090@qq.com>
@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 11, 2025

Hi @PurpleViper3. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JiGuoDing
Copy link
Copy Markdown
Collaborator

JiGuoDing commented Mar 11, 2025

Hello @PurpleViper3, please do not modify the code in other locations, and ensure that there is no blank line between the comments and the function. Thanks.

Signed-off-by: cbkjames23 <1411137090@qq.com>
@sonarqubecloud
Copy link
Copy Markdown

@PurpleViper3
Copy link
Copy Markdown
Contributor Author

Sorry,I don't know why the compiler automatically deletes that line of code after i add a comment. I recover the code and delete the empty line between func and comment. Thanks @JiGuoDing

Copy link
Copy Markdown
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link
Copy Markdown

fluid-e2e-bot Bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang
Copy link
Copy Markdown
Collaborator

cheyang commented Mar 20, 2025

/ok-to-test

@cheyang cheyang merged commit 7d914d2 into fluid-cloudnative:master Mar 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestGetMasterPodInfo in pkg\ddc\alluxio\utils_test.go.

3 participants